[lvc-project] [PATCH v2] vgem: fix error return in vgem_init()
Markus Elfring
Markus.Elfring at web.de
Fri Oct 3 17:42:11 MSK 2025
> The dma_coerce_mask_and_coherent function may
> fail to apply a mask due to incorrectly passed parameters.
…
* You may occasionally put more than 61 characters into text lines
of such a change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17#n658
* Would you like to choose another imperative wording?
* How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
…
> ---
> drivers/gpu/drm/vgem/vgem_drv.c | 4 +++-
…
Some contributors would appreciate patch version descriptions.
https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22
…
> +++ b/drivers/gpu/drm/vgem/vgem_drv.c
> @@ -140,8 +140,10 @@ static int __init vgem_init(void)
> goto out_unregister;
> }
>
> - dma_coerce_mask_and_coherent(&pdev->dev,
> + ret = dma_coerce_mask_and_coherent(&pdev->dev,
> DMA_BIT_MASK(64));
> + if (ret)
> + goto out_unregister;
…
I suggest to keep the passed parameters in the same line for this function call.
Regards,
Markus
More information about the lvc-project
mailing list