[lvc-project] [PATCH] ocfs2: add inline inode consistency check to ocfs2_validate_inode_block()

[Joseph Qi]

On 2025/10/23 22:16, Dmitry Antipov wrote:
> In 'ocfs2_validate_inode_block()', add an extra check whether an inode
> with inline data (i.e. self-contained) has no clusters, thus preventing
> an invalid inode from being passed to 'ocfs2_evict_inode()' and below.
> 
> Reported-by: syzbot+c16daba279a1161acfb0 at syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=c16daba279a1161acfb0
> Signed-off-by: Dmitry Antipov <dmantipov at yandex.ru>

Looks fine.
Reviewed-by: Joseph Qi <joseph.qi at linux.alibaba.com>

> ---
>  fs/ocfs2/inode.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
> index fcc89856ab95..5fad0a56cc98 100644
> --- a/fs/ocfs2/inode.c
> +++ b/fs/ocfs2/inode.c
> @@ -1503,6 +1503,14 @@ int ocfs2_validate_inode_block(struct super_block *sb,
>  		goto bail;
>  	}
>  
> +	if ((le16_to_cpu(di->i_dyn_features) & OCFS2_INLINE_DATA_FL) &&
> +	    le32_to_cpu(di->i_clusters)) {
> +		rc = ocfs2_error(sb, "Invalid dinode %llu: %u clusters\n",
> +				 (unsigned long long)bh->b_blocknr,
> +				 le32_to_cpu(di->i_clusters));
> +		goto bail;
> +	}
> +
>  	rc = 0;
>  
>  bail: