[lvc-project] [PATCH 2/2] ocfs2: validate cl_bpc in allocator inodes to prevent divide-by-zero

[Joseph Qi]

On 2025/10/29 14:54, Dmitry Antipov wrote:
> On 10/29/25 9:26 AM, Deepanshu Kartikey wrote:
>> Hi Dmitry,
>>
>> Thanks for combining the patches! The series looks good overall.  One
>> suggestion: Would it be possible to display both the corrupted and
>> expected values in the error message?
>> Like: "Invalid dinode %llu: bits per cluster %u, expected %u\n" . This
>> would help administrators understand what the correct value should be,
>> which is especially useful during fsck operations. Everything else
>> looks great!
> 
> Well, since the messages issued by ocfs2_validate_inode_block() are quite
> brief, I just fit it into common style, and would prefer to leave the final
> decision to the maintainer.

Seems fine, the expected bpc can simply gotten using ocfs2 tools.

Joseph