[lvc-project] [PATCH] nvme-apple: drop invalid put of admin queue reference count
Fedor Pchelkin
pchelkin at ispras.ru
Wed Apr 8 16:57:21 MSK 2026
On Mon, 06. Apr 20:20, Jens Axboe wrote:
> On 4/3/26 2:27 PM, Fedor Pchelkin wrote:
> > @@ -1269,8 +1269,6 @@ static void apple_nvme_free_ctrl(struct nvme_ctrl *ctrl)
> > {
> > struct apple_nvme *anv = ctrl_to_apple_nvme(ctrl);
> >
> > - if (anv->ctrl.admin_q)
> > - blk_put_queue(anv->ctrl.admin_q);
> > put_device(anv->dev);
> > }
>
> Could this just be:
>
> static void apple_nvme_free_ctrl(struct nvme_ctrl *ctrl)
> {
> put_device(ctrl->dev);
> }
>
> at this point?
Right, ctrl->dev and anv->dev point to the same device. I'll simplify in v2.
More information about the lvc-project
mailing list