[lvc-project] [PATCH] usb: typec: tcpm: qcom: initialize currsrc explicitly
Alexey V. Vissarionov
gremlin at altlinux.org
Mon Jul 13 21:22:57 MSK 2026
Good ${greeting_time}!
On 2026-07-13 09:34:22 +0100, Bryan O'Donoghue wrote:
> On 13/07/2026 09:06, Alexey V. Vissarionov wrote:
>> When regmap_read() fails, the execution goes to done: label,
>> where currsrc is passed to rp_sel_to_name() and used as an
>> index after a proper check. However, to make this situation
>> easier to notice, an explicit initialization of currsrc with
>> obviously impossible value is suggested.
>> [...]
>> Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC
>> Type-C driver")
>> Signed-off-by: Alexey V. Vissarionov <gremlin at altlinux.org>
> This patch makes sense but doesn't require a Fixes: tag.
> With that changed.
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue at linaro.org>
ACK. Updated patch follows.
--
Alexey V. Vissarionov
gremlin ПРИ altlinux ТЧК org; +vii-cmiii-ccxxix-lxxix-xlii
GPG: 0D92F19E1C0DC36E27F61A29CD17E2B43D879005 @ hkp://keys.gnupg.net
More information about the lvc-project
mailing list