[lvc-project] [PATCH v2 5.10/5.15] RDMA/rxe: Fix the error "trying to register non-static key in rxe_cleanup_task"
Vladislav Nikolaev
vlad102nikolaev at gmail.com
Fri Jun 5 20:37:21 MSK 2026
On Wed, 3 Jun 2026 at 18:03:00 +0300, Fedor Pchelkin wrote:
> Moving it a couple of lines around requires some explanation why it's
> okay in 5.10/5.15 kernels. Note that in upstream it was done by another
> commit 960ebe97e523 ("RDMA/rxe: Remove __rxe_do_task()").
>
> [ yeah, it should be safe to move the call but it'd better be stated
> explicitly in the backporter's comment ]
>
> Worth saying that checkpatch.pl for the current patch gives:
>
> ERROR: trailing whitespace
> #52: FILE: drivers/infiniband/sw/rxe/rxe_qp.c:771:
> +^I$
>
> You might also want to consider porting 1c7eec4d5f3b ("RDMA/rxe: Fix
> "trying to register non-static key in rxe_qp_do_cleanup" bug") which fixes
> the similar problem for del_timer_sync / timer_delete_sync calls in this
> code. This all could go as a series now probably.
Thanks for the review.
I have prepared v3 as a 5.10/5.15 series and addressed all three points:
1. extended the backporter's comment to explain why moving
rxe_cleanup_task(&qp->resp.task) after the RC timer cleanup is safe
for 5.10/5.15 even though upstream got that order via 960ebe97e523;
2. fixed the trailing whitespace;
3. added the backport of 1c7eec4d5f3b as the second patch in the series.
The updated series is available here:
https://lore.kernel.org/all/20260605171449.1760-1-vlad102nikolaev@gmail.com/
More information about the lvc-project
mailing list