[lvc-project] [PATCH 5.10 491/491] io_uring/poll: correctly handle io_poll_add() return value on update

[Jens Axboe]

On 5/1/26 4:29 PM, Jens Axboe wrote:
> On 5/1/26 4:26 PM, Fedor Pchelkin wrote:
>>> @@ -6188,7 +6184,7 @@ static int io_poll_update(struct io_kiocb *req, unsigned int issue_flags)
>>>  		preq->result = ret2;
>>>  
>>>  	}
>>> -	if (preq->result < 0)
>>> +	if (ret2 < 0)
>>>  		req_set_fail(preq);
>>>  	io_req_complete(preq, preq->result);
>>>  out:
>>
>> I'm really uncomfortable to raise this but - ret2 should be initialized in
>> beginning of the function io_poll_update().
> 
> It's your second version... I'll send out a new set.

OK, here's the new set for both 5.10-stable and 5.15-stable. Ran it through the
usual testing.

Let's hope we can put this one to bed now :-)

-- 
Jens Axboe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-io_uring-poll-fix-EPOLL_URING_WAKE-sometimes-not-bei.patch
Type: text/x-patch
Size: 1809 bytes
Desc: not available
URL: <http://linuxtesting.org/pipermail/lvc-project/attachments/20260501/01bc5bd7/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-io_uring-poll-fix-backport-of-io_poll_add-changes.patch
Type: text/x-patch
Size: 1859 bytes
Desc: not available
URL: <http://linuxtesting.org/pipermail/lvc-project/attachments/20260501/01bc5bd7/attachment-0001.bin>