<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=windows-1252">
</head>
<body>
<br>
<div class="moz-forward-container">-------- Forwarded Message
--------
<table class="moz-email-headers-table" cellspacing="0"
cellpadding="0" border="0">
<tbody>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">Subject:
</th>
<td>Re: [PATCH] iommu/io-pgtable-arm: Remove iommu_dev==NULL
special case</td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">Date: </th>
<td>Wed, 7 Sep 2022 14:19:04 +0200</td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">From: </th>
<td>Joerg Roedel <a class="moz-txt-link-rfc2396E" href="mailto:joro@8bytes.org"><joro@8bytes.org></a></td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">To: </th>
<td>Robin Murphy <a class="moz-txt-link-rfc2396E" href="mailto:robin.murphy@arm.com"><robin.murphy@arm.com></a></td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">CC: </th>
<td><a class="moz-txt-link-abbreviated" href="mailto:will@kernel.org">will@kernel.org</a>, <a class="moz-txt-link-abbreviated" href="mailto:iommu@lists.linux.dev">iommu@lists.linux.dev</a>,
<a class="moz-txt-link-abbreviated" href="mailto:subkhankulov@ispras.ru">subkhankulov@ispras.ru</a>, <a class="moz-txt-link-abbreviated" href="mailto:khoroshilov@ispras.ru">khoroshilov@ispras.ru</a>,
<a class="moz-txt-link-abbreviated" href="mailto:linux-kernel@vger.kernel.org">linux-kernel@vger.kernel.org</a></td>
</tr>
</tbody>
</table>
<br>
<br>
On Mon, Aug 15, 2022 at 05:15:55PM +0100, Robin Murphy wrote:<br>
<blockquote type="cite">The special case to allow iommu_dev==NULL
in __arm_lpae_alloc_pages() is<br>
confusing to static checkers (and possibly readers in general),
since<br>
it's not obvious that that is only intended for the selftests.
However<br>
it only serves to get around the dev_to_node() call, and we can
easily<br>
fake up enough to make that work anyway, so let's simply remove
this<br>
consideration from the normal flow and punt the responsibility
over to<br>
the test harness itself.<br>
<br>
Reported-by: Rustam Subkhankulov <a class="moz-txt-link-rfc2396E" href="mailto:subkhankulov@ispras.ru"><subkhankulov@ispras.ru></a><br>
Signed-off-by: Robin Murphy <a class="moz-txt-link-rfc2396E" href="mailto:robin.murphy@arm.com"><robin.murphy@arm.com></a><br>
</blockquote>
<br>
Applied, thanks.<br>
</div>
</body>
</html>