<html><body><div style="font-size: 12pt; font-family: arial, helvetica, sans-serif; color: rgb(0, 0, 0);"><div style="font-size: 12pt; font-family: 'arial' , 'helvetica' , sans-serif; color: #000000;">
<div style="font-size: 12pt; font-family: 'arial' , 'helvetica' , sans-serif; color: #000000;">
<div> </div>
<div> </div>
<div id="signature-content-no-signature"></div>
<div>
<div id="OLK_SRC_BODY_SECTION">
<div id="OLK_SRC_BODY_SECTION">
<blockquote style="margin: 0 0 0 0.8em; border-left: 1px #ccc solid; padding-left: 1em;"><hr id="MESSAGE_DATA_MARKER"><strong>From: </strong>Christophe <christophe.leroy@csgroup.eu><br><strong>To: </strong>Ekaterina <eesina@astralinux.ru>; Zhao <qiang.zhao@nxp.com><br><strong>Cc: </strong>lvc-project <lvc-project@linuxtesting.org>; netdev <netdev@vger.kernel.org>; linux-kernel <linux-kernel@vger.kernel.org>; Eric <edumazet@google.com>; Jakub <kuba@kernel.org>; Paolo <pabeni@redhat.com>; linuxppc-dev <linuxppc-dev@lists.ozlabs.org>; David <davem@davemloft.net><br><strong>Date: </strong>Monday, 9 January 2023 6:49 PM MSK<br><strong>Subject: </strong>Re: [PATCH] net-wan: Add check for NULL for utdm in ucc_hdlc_probe<br><br><br><br>Le 23/12/2022 à 15:32, Ekaterina Esina a écrit : <br>> [Vous ne recevez pas souvent de courriers de eesina@astralinux.ru. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] <br>> <br>> If uhdlc_priv_tsa != 1 then utdm is not initialized. <br>> And if ret != NULL then goto undo_uhdlc_init, where utdm is dereferenced. <br>> Same if dev == NULL. <br>> <br>> Found by Linux Verification Center (linuxtesting.org) with SVACE. <br>> <br>> Signed-off-by: Ekaterina Esina <eesina@astralinux.ru> <br>> --- <br>> drivers/net/wan/fsl_ucc_hdlc.c | 4 +++- <br>> 1 file changed, 3 insertions(+), 1 deletion(-) <br>> <br>> diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c <br>> index 22edea6ca4b8..2ddb0f71e648 100644 <br>> --- a/drivers/net/wan/fsl_ucc_hdlc.c <br>> +++ b/drivers/net/wan/fsl_ucc_hdlc.c <br>> @@ -1243,7 +1243,9 @@ static int ucc_hdlc_probe(struct platform_device *pdev) <br>> free_dev: <br>> free_netdev(dev); <br>> undo_uhdlc_init: <br>> - iounmap(utdm->siram); <br>> + if (utdm != NULL) { <br>> + iounmap(utdm->siram); <br>> + } <br><br>If utdm being NULL is a problem here, isn't it also a problem in the <br>iounmap below ? <br><br><br>> unmap_si_regs: <br>> iounmap(utdm->si_regs); <br>> free_utdm: <br>> -- <br>> 2.30.2 <br>></blockquote>
<blockquote style="margin: 0 0 0 0.8em; border-left: 1px #ccc solid; padding-left: 1em;">Yes, below the check is also needed. I guess I should send a new patch with both checks</blockquote>
<blockquote style="margin: 0 0 0 0.8em; border-left: 1px #ccc solid; padding-left: 1em;">Best wishes,</blockquote>
<blockquote style="margin: 0 0 0 0.8em; border-left: 1px #ccc solid; padding-left: 1em;">Ekaterina Esina</blockquote>
</div>
</div></div>
</div>
</div></div></body></html>