<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">2023년 12월 20일 (수) 오후 7:45, Marek Szyprowski <<a href="mailto:m.szyprowski@samsung.com">m.szyprowski@samsung.com</a>>님이 작성:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 20.12.2023 10:53, Fedor Pchelkin wrote:<br>
> Do not forget to call clk_disable_unprepare() on the first element of<br>
> ctx->clocks array.<br>
><br>
> Found by Linux Verification Center (<a href="http://linuxtesting.org" rel="noreferrer noreferrer" target="_blank">linuxtesting.org</a>).<br>
><br>
> Fixes: 8b7d3ec83aba ("drm/exynos: gsc: Convert driver to IPP v2 core API")<br>
> Signed-off-by: Fedor Pchelkin <<a href="mailto:pchelkin@ispras.ru" target="_blank" rel="noreferrer">pchelkin@ispras.ru</a>><br>
Reviewed-by: Marek Szyprowski <<a href="mailto:m.szyprowski@samsung.com" target="_blank" rel="noreferrer">m.szyprowski@samsung.com</a>><br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Applied.</div><div dir="auto"><br></div><div dir="auto">Thanks,</div><div dir="auto">Inki Dae</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
> ---<br>
> drivers/gpu/drm/exynos/exynos_drm_gsc.c | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c<br>
> index 34cdabc30b4f..5302bebbe38c 100644<br>
> --- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c<br>
> +++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c<br>
> @@ -1342,7 +1342,7 @@ static int __maybe_unused gsc_runtime_resume(struct device *dev)<br>
> for (i = 0; i < ctx->num_clocks; i++) {<br>
> ret = clk_prepare_enable(ctx->clocks[i]);<br>
> if (ret) {<br>
> - while (--i > 0)<br>
> + while (--i >= 0)<br>
> clk_disable_unprepare(ctx->clocks[i]);<br>
> return ret;<br>
> }<br>
<br>
Best regards<br>
-- <br>
Marek Szyprowski, PhD<br>
Samsung R&D Institute Poland<br>
<br>
</blockquote></div></div></div>