
<html><p><br><br>Четверг, Март 27, 2025 18:10 MSK, Tigran Sogomonian <tsogomonian@astralinux.ru> писал(а):<br><br> </p><blockquote type="cite" cite="20250327151109.9648-1-tsogomonian@astralinux.ru"><p>To avoid division by zero, a check was added to the prate<br>variable, since no guarantees were found that it could not<br>be equal to zero.<br><br>Found by Linux Verification Center (linuxtesting.org) with SVACE.<br><br>Signed-off-by: Tigran Sogomonian <tsogomonian@astralinux.ru><br>---<br>drivers/clk/renesas/rcar-gen3-cpg.c | 2 ++<br>drivers/clk/renesas/rcar-gen4-cpg.c | 2 ++<br>2 files changed, 4 insertions(+)<br><br>diff --git a/drivers/clk/renesas/rcar-gen3-cpg.c b/drivers/clk/renesas/rcar-gen3-cpg.c<br>index 027100e84ee4..66da3b4398cd 100644<br>--- a/drivers/clk/renesas/rcar-gen3-cpg.c<br>+++ b/drivers/clk/renesas/rcar-gen3-cpg.c<br>@@ -205,6 +205,8 @@ static int cpg_z_clk_determine_rate(struct clk_hw *hw,<br>prate * zclk->fixed_div);<br><br>prate = req->best_parent_rate / zclk->fixed_div;<br>+ if (prate == 0)<br>+ return -EINVAL;<br>min_mult = max(div64_ul(req->min_rate * 32ULL, prate), 1ULL);<br>max_mult = min(div64_ul(req->max_rate * 32ULL, prate), 32ULL);<br>if (max_mult < min_mult)<br>diff --git a/drivers/clk/renesas/rcar-gen4-cpg.c b/drivers/clk/renesas/rcar-gen4-cpg.c<br>index 31aa790fd003..4c9a7d699290 100644<br>--- a/drivers/clk/renesas/rcar-gen4-cpg.c<br>+++ b/drivers/clk/renesas/rcar-gen4-cpg.c<br>@@ -308,6 +308,8 @@ static int cpg_z_clk_determine_rate(struct clk_hw *hw,<br>prate * zclk->fixed_div);<br><br>prate = req->best_parent_rate / zclk->fixed_div;<br>+ if (prate == 0)<br>+ return -EINVAL;<br>min_mult = max(div64_ul(req->min_rate * 32ULL, prate), 1ULL);<br>max_mult = min(div64_ul(req->max_rate * 32ULL, prate), 32ULL);<br>if (max_mult < min_mult)<br>-- <br>2.47.1<br><br> </p></blockquote><p><span style="background-color:rgb(255,255,255);color:rgba(0,0,0,0.87);"><span style="-webkit-text-stroke-width:0px;display:inline !important;float:none;font-family:"Fira sans", "Helvetica Neue", sans-serif;font-size:medium;font-style:normal;font-variant-caps:normal;font-variant-ligatures:normal;font-weight:400;letter-spacing:normal;orphans:2;text-align:start;text-decoration-color:initial;text-decoration-style:initial;text-decoration-thickness:initial;text-indent:0px;text-transform:none;white-space:pre-wrap;widows:2;word-spacing:0px;">Just a friendly reminder)</span></span><br><br><br> </p></html>