[lvc-project] [PATCH 1/1] media: atomisp: Avoid memory leaks in ia_css_pipe_create_cas_scaler_desc_single_output()

[Ivan Abramov]

If any of the memory allocations for descr struct members fail, goto ERR is
executed, and none of the previously allocated memory is freed, which leads
to leaking memory.

Fix this by freeing memory at the end of the function in case of an
non-NULL err.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Ivan Abramov <i.abramov at mt-integration.ru>
---
 drivers/staging/media/atomisp/pci/sh_css.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/staging/media/atomisp/pci/sh_css.c b/drivers/staging/media/atomisp/pci/sh_css.c
index 73bd87f43a8c..d50bc81a59dc 100644
--- a/drivers/staging/media/atomisp/pci/sh_css.c
+++ b/drivers/staging/media/atomisp/pci/sh_css.c
@@ -5907,6 +5907,10 @@ static int ia_css_pipe_create_cas_scaler_desc_single_output(
 	ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE,
 			    "ia_css_pipe_create_cas_scaler_desc() leave, err=%d\n",
 			    err);
+
+        if (err)
+                ia_css_pipe_destroy_cas_scaler_desc(descr);
+
 	return err;
 }
 
-- 
2.39.5