[Home]

Issue of the Implementation # L0002

Brief

fs/cifs/cifsencrypt.c: Memory leakage

Detailed Description

 In function calc_ntlmv2_hash memory is not released.

1. If in the line 333 we successfully allocate memory and assign it to pctxt variable:         pctxt = kmalloc(sizeof(struct HMACMD5Context), GFP_KERNEL); then we go to line 376 and exit wihout releasing memory pointed to by pctxt variable.

Possible solutions

---
diff --git a/a/fs/cifs/cifsencrypt.c b/b/fs/cifs/cifsencrypt.c
index 7c98095..7efe174 100644
--- a/a/fs/cifs/cifsencrypt.c
+++ b/b/fs/cifs/cifsencrypt.c
@@ -373,6 +373,7 @@ calc_exit_2:
           compare with the NTLM example */
        hmac_md5_final(ses->server->ntlmv2_hash, pctxt);

+       kfree(pctxt);
        return rc;
 }

Component

linux-kernel 2.6.30.4

Accepted

http://lkml.org/lkml/2009/8/11/210
commit

Status

Fixed in kernel 2.6.32

[Home]