[Home]

Issue of the Implementation # L0024

Brief

pohmelfs/dir.c: unneeded mutex_unlock() in pohmelfs_rename()

Detailed Description

Mutex unlocking on error path without previously locking in function pohmelfs_rename() in line 1085

1079        return 0;
1080
1081err_out_exit:
1082
1083        clear_bit(NETFS_INODE_REMOTE_SYNCED, &pi->state);
1084
1085        mutex_unlock(&inode->i_mutex);
1086        return err;
1087}

Possible solutions

diff --git a/drivers/staging/pohmelfs/dir.c b/drivers/staging/pohmelfs/dir.c
index 059e9d2..9732a96 100644
--- a/drivers/staging/pohmelfs/dir.c
+++ b/drivers/staging/pohmelfs/dir.c
@@ -1082,7 +1082,6 @@ err_out_exit:

        clear_bit(NETFS_INODE_REMOTE_SYNCED, &pi->state);

-       mutex_unlock(&inode->i_mutex);
        return err;
 }

Component

linux-kernel 2.6.37

Accepted

https://lkml.org/lkml/2011/1/19/334
commit

Status

Fixed in kernel 2.6.39-rc1

[Home]